-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: use Local version of ToBoolean() #24924
Conversation
Isn't this removing a check? I'm not familiar with this code but it removes something about a boolean expected? |
I don't think so. The compiler warning is:
And, the |
@targos I’m not sure which check you’re referring to – |
It's just that I see |
@targos |
Yellow resume CI: https://ci.nodejs.org/job/node-test-commit/24194/ |
This fixes a deprecation warning. PR-URL: nodejs#24924 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: James M Snell <[email protected]>
This fixes a deprecation warning. PR-URL: #24924 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: James M Snell <[email protected]>
This fixes a deprecation warning. PR-URL: nodejs#24924 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: James M Snell <[email protected]>
This fixes a deprecation warning.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes